-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lidar_apollo_instance_segmentation, tensorrt_common): use onnx instead of caffe for apollo cnnseg #3320
Conversation
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3320 +/- ##
==========================================
- Coverage 12.40% 12.40% -0.01%
==========================================
Files 1368 1368
Lines 96191 96189 -2
Branches 27724 27724
==========================================
- Hits 11931 11930 -1
+ Misses 71594 71592 -2
- Partials 12666 12667 +1
*This pull request uses carry forward flags. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
before(caffe) |
Thank you for PR 👍 |
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
@wep21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yukkysaito You're the code owner of |
Description
🤖 Generated by Copilot at 3b4cb35
This pull request updates the
lidar_apollo_instance_segmentation
package and its dependencies to use the new TensorRT and CUDA libraries for faster and more robust lidar-based instance segmentation. It also improves the code quality, style, and consistency of the package by adding namespaces, include guards, license headers, and fixing typos and braces. It also simplifies the launch file and the.gitignore
file by using the.onnx
format for the neural network models.Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.